Update LogicalTestingFallacies with Raphaël Moll's contributions.
diff --git a/LogicalTestingFallacies.wiki b/LogicalTestingFallacies.wiki index f2230da..3508206 100644 --- a/LogicalTestingFallacies.wiki +++ b/LogicalTestingFallacies.wiki
@@ -1,7 +1,7 @@ #summary "Why My Patch Doesn't Need Tests" #labels Importance-Useful,Phase-QA,Contents-Complete -Author: Adrienne Walker (a colleague of Nathaniel's at Google) +Author: Adrienne Walker and Raphaël Moll (colleagues of Nathaniel's at Google) ==_Appeal To Importance_== @@ -19,10 +19,18 @@ There’s no good way to write these tests easily, so I shouldn’t need to write them. +==_Insufficient Coverage Argument_== + +The tests requires extensive mocking (of servers, RPCs, filesystems, 3d party libs with their own side-effects, GUI) and would thus not test the real system but a limited fictional subsystem. Such tests would be totally irrelevant so they need not be written. + ==_Just a Refactoring Argument_== All functionality in this patch is already entirely covered by preexisting tests. Trust me. ==_Promise Of Future Work_== -I pinky-swear that I will write a follow-up CL that adds tests, just as soon as I fix these other things first... \ No newline at end of file +I pinky-swear that I will write a follow-up CL that adds tests, just as soon as I fix these other things first... + +==_The Proof is in the Pudding_== + +We're already using this for releases. It clearly works so we don't need to write tests. At this point we empirically have full coverage and just found a couple minor bugs. \ No newline at end of file